Skip to content

Conversation

@eregon
Copy link
Member

@eregon eregon commented May 28, 2025

@eregon eregon force-pushed the fix-win32ole-warnings branch 2 times, most recently from a65b6fb to af62739 Compare May 28, 2025 21:32
@eregon
Copy link
Member Author

eregon commented May 28, 2025

https://github.com/ruby/spec/actions/runs/15311063783/job/43075606821?pr=1270
So the trouble is 3.2 and 3.3 don't have WIN32OLE::TypeLib, only 3.4 has.
And the previous constant WIN32OLE_TYPELIB is already deprecated in 3.4.
So that's pretty immediate deprecation of https://github.com/ruby/win32ole with no overlap to migrate.

@eregon eregon force-pushed the fix-win32ole-warnings branch from af62739 to 2793619 Compare May 28, 2025 21:40
@eregon
Copy link
Member Author

eregon commented May 28, 2025

Trying the first option in #1240 (comment)

@eregon eregon force-pushed the fix-win32ole-warnings branch from 036e17f to 29e0fe4 Compare May 28, 2025 21:54
@eregon eregon merged commit 8369559 into master May 28, 2025
24 checks passed
@eregon eregon deleted the fix-win32ole-warnings branch May 28, 2025 22:09
@eregon
Copy link
Member Author

eregon commented May 28, 2025

cc @nobu this should fix the win32ole warnings properly on Ruby 3.4+ in ruby/spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants